Skip to content

Rollup is including lodash code inside the ESM build #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DavidEspinola opened this issue Aug 12, 2020 · 0 comments
Closed

Rollup is including lodash code inside the ESM build #541

DavidEspinola opened this issue Aug 12, 2020 · 0 comments

Comments

@DavidEspinola
Copy link

Since rollup.config.esm.js is configuring "external" as the full lodash library but imports are including specific modules, this config is not taking effect and Rollup is including a large ammount of lodash code in the ESM bundle.

Fixing this configuration reduces bundle size to less than a half, so I think is something good to include. I'll be happy to include this optimization in my projects.

@DavidEspinola DavidEspinola changed the title Rollup is including lodash code inside the ESM build Rollup is including lodash code inside the ESM build. Fixes #541 Aug 12, 2020
@DavidEspinola DavidEspinola changed the title Rollup is including lodash code inside the ESM build. Fixes #541 Rollup is including lodash code inside the ESM build Aug 12, 2020
@Akryum Akryum closed this as completed in 12a8dab Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant