chore: prevent lodash inclusion when building esm #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidEspinola
changed the title
DavidEspinola
changed the title
|
@Akryum What do you think about this? Another option is to use smaller lodash packages like https://www.npmjs.com/package/lodash.merge and https://www.npmjs.com/package/lodash.isequal and populate the Relloup "external" configuration importing package.json dependencies. I can prepare another pull request if you prefer this option. |
|
Thank you for you PR! Fixed in 12a8dab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rollup.config.esm.js is configuring "external" as the full lodash library but imports are including specific modules, this config is not taking effect and Rollup is including a large ammount of lodash code in the ESM bundle.
Fixing this configuration reduces bundle size to less than a half, so I think is something good to include. I'll be happy to include this optimization in my projects.
I have included the version increment and compiled build, but I can remove them if you have another workflow. Fixes #541
Regards