Export added for top level declaration #464
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tslint says: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier. This PR resolve this issue adding export to top level declaration in d.ts file.
|
@frkcn amazing! for now, i'm importing with "require" to workaround this. |
Closed
|
Confirm this PR is OK |
|
@Akryum merge please? :) |
|
please close this MR. the fix is incorrect (it changes the public interface of the module). #464 is correct, by using |
|
Duplicate of #462 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tslint says: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.
This PR resolve this issue adding export to top level declaration in d.ts file.