Skip to content

hideSelectColumn not working in table header #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ddorsett opened this issue Mar 6, 2017 · 4 comments
Closed

hideSelectColumn not working in table header #1122

ddorsett opened this issue Mar 6, 2017 · 4 comments
Labels
in progress

Comments

@ddorsett
Copy link

ddorsett commented Mar 6, 2017

I am getting a blank table cell in the header row. It's appears to be coming from a SelectRowHeaderColumn component, although I am passing in mode: 'radio' and hideSelectColumn: true as part of the selectRow object in the table properties.
When I don't include 'hideSelectColumn: true', the table header is fine. I really don't want the radio buttons (unneccessary waste of UI in my case)
@JohnUiterwyk
Copy link
Contributor

I'm also having this issue

JohnUiterwyk added a commit to JohnUiterwyk/react-bootstrap-table that referenced this issue Mar 7, 2017
@JohnUiterwyk
Fix hideSelectColumn not working in table header
fcc7c81 
Fixes issue: AllenFang#1122
@JohnUiterwyk JohnUiterwyk mentioned this issue Mar 7, 2017
Merged
@ddorsett
Copy link
Author

ddorsett commented Mar 7, 2017

That patch did it for me- Thanks John!

@AllenFang
Copy link
Owner

sorry guys, I'm pretty busy on my job, I'll have a look for this PR and merge it as soon as possible. Thanks :)

@AllenFang
Copy link
Owner

Released on v3.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JohnUiterwyk @AllenFang @ddorsett