Skip to content

Ability to remove the blank comparator options from filters #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sean-ww opened this issue Apr 21, 2017 · 3 comments
Closed

Ability to remove the blank comparator options from filters #1248

sean-ww opened this issue Apr 21, 2017 · 3 comments

Comments

@sean-ww
Copy link

sean-ww commented Apr 21, 2017

When setting a default comparator, in many cases, the blank comparator option will no longer be required. Could the blank comparator option be made optional?
e.g.

filter={ { 
    type: 'NumberFilter', 
    numberComparators: [ '=', '>', '<=' ],
    defaultValue: { number: 50, comparator: '>' },
    forceSelect: true
} }

With forceSelect removing the blank comparator option.

@AllenFang
Copy link
Owner

@sean-ww, I'll consider to support this feature if there's no any critical problem on implement this feature, thanks

@sean-ww
Copy link
Author

sean-ww commented Apr 23, 2017

Thanks @AllenFang. If it defaults to false, it shouldn't cause any issues.

AllenFang added a commit that referenced this issue Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants