-
Notifications
You must be signed in to change notification settings - Fork 775
Using custom components for cell editing #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@markmywords, thanks you this component. I thinks the data picker can be included to the core, but upload field is a little bad idea, it need a custom component for user to define their editing component. So I need sometime to think about that :) In addition, if you have any questions, feel free to ask |
Hi and thank you for your fast reply. Yeah, a file uploader might not be a use case for a lot of people and I just wanted to use it as an example. What I needed for example was a select field where I can store an object id as value and display the object name at the same time. For this I just added the following to Editor.js:
And in TableEditColumn.js I changed
to
It works fine but I don't know if this a good solution in react.js. I posted this issue to see if there is interest and maybe someone else is looking for a way to do something similar :) And thanks for providing this great library btw! |
It's seems like good at my first seeing, maybe you can make a PR and I can help you to make this cool feature be better :) |
+1 for the datepicker in editing + inserting new data. |
Any file uploader on the horizon? |
hi @battarro and @dannysindra, Hope I can support it in recently, but I'm busy on my work, so PR is welcome. I promise I'll keep these asking feature in my mind, but there're a lot of things to do so that any improvement will be slow currently. sorry guys ;( |
Released on |
|
Hi there,
I was wondering if the ability of using custom components for cell editing wouldn't be a nice feature to have. Use cases could be file upload fields or date pickers. Adding such editors to the core would probably be out of scope but the ability to define and pass custom editor components to react-bootstrap-table certainly would be nice.
I already forked the project and had a go at it myself but I am not (yet!) a react.js pro, so I am unsure if my strategy for implement is the way to go or not :)
The text was updated successfully, but these errors were encountered: