-
Notifications
You must be signed in to change notification settings - Fork 775
Adding ability to provide custom editors #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- On a column you can specify customEditor - pass in a react component class
@abhirao, it's seems look like good at first sight. Maybe can released on BTW, thanks your contribution |
PropTypes.bool, | ||
PropTypes.number, | ||
PropTypes.object | ||
]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AllenFang I'm not sure what the impact is of changing the fieldValue (which used to come in as children) from node to the 4 types I have listed.
@AllenFang Thank you very much for creating this library! Sorry I was traveling last week and didn't get a chance to respond to you. I'm not sure what the timeline is for v3.0.0 but I think our team would like the custom cell editing sooner. I can definitely help with this. |
@abhirao, that's awesome, I'll expect your contribution:) So I just keep this PR open and wait your confirm for completion. BTW, if you complete this PR and if I almost finish |
I analyzed the backwards compatibility of this PR and I think it should be fine. The only prop type that is changing is for editable columns for the field values. My current implementation of custom editors is following a different pattern than custom filters. I'm going to do a little refactor to make the customEditor work the same way as filter. |
- Need to pass in a factory method and custom properties
@AllenFang I've updated the interface for my custom editor implementation to match the custom filter interface. Custom Editor:
Custom Filter:
I think it's good to go. What do you think? Let me know if/how I can help with documentation. |
@abhirao, that's awesome :) I'll spend some time to review this PR. But need some time, it's busy in these day ;( Anyway, you did a great job and thanks you! |
@AllenFang You're welcome. Thank you very much for all you do keep this project going 🙇 . |
Just a passion on it to keep me to contribute this repo. I'm busy in the recent, but I think I can back in next month! Anyway, if u r interesting for contributing this repo at long term, welcome to discuss with me :) |
@abhirao, I need to say thanks again. This PR has been released on |
Addresses #162