-
Notifications
You must be signed in to change notification settings - Fork 775
Sorting field and order is not taken from props when using remote datasource #1752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
…sing remote datasource
I created pull request to fix it. Please review it here: #1753 |
@aalbul I'll check this out, thanks |
@aalbul I've some feedbacks on PR |
Thanks, please see my answer in PR :) |
@aalbul released on |
Prior to this change, clearing a sort used to work by:
Doing this with 4.2.0 (I would assume in 4.1.5 - I just tried upgrading from 4.1.4) results in BootstrapTable throwing the error: The changes made for this issue do not take into account/provide any way to reset the current sort without triggering the above error. i.e. |
…sing remote datasource
I found that when i use remote datasource, there is no way to reset / change sortName or sortOrder.
My use case is pretty easy. I store table data, pagination data + sorting data in redux. When i change sorting field in Redux (and not by clicking on header), this change is not reflected in the table.
This is happening because this data is not synchronised back into store inside of BootstrapTable.componentWillReceiveProps method.
The text was updated successfully, but these errors were encountered: