Skip to content

Pagination should use react-bootstrap #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sgentile opened this issue May 3, 2016 · 2 comments
Closed

Pagination should use react-bootstrap #434

sgentile opened this issue May 3, 2016 · 2 comments

Comments

@sgentile
Copy link

sgentile commented May 3, 2016

Looking at this issue:
#338

I believe if that pagination was written with react-bootstrap it would eliminate the need for the bootstrap.js (and even better, jQuery).

imo - this component since it uses react-bootstrap should use it and not depend on the bootstrap.js file separately

@mkozhukharenko
Copy link

+1! Why on earth the bootstrap.js must be included to a projec to make a dropdown (from a pagination module) work?

@AllenFang
Copy link
Owner

hey guys, thanks your suggestion. At the beginning of this project, I also thinks about a dependency on react-bootstrap. But I thinks it's not necessary really and if it depends, there will be a lots of dependency problems. so I just want to isolate it and let user to handle bootstrap.

But to now, I feel the same pain on the depends of bootstrap.js, so this issue has been created on #197 and #232 has tried to fix it.

Anyway, because something missing so I revert #232, and hope I can fix this issues in near future. So I just close this issues and please follow up #197

Thank you guys :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants