-
Notifications
You must be signed in to change notification settings - Fork 775
Fix #197 #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #197 #232
Conversation
@@ -48,6 +48,7 @@ | |||
"react-bootstrap": "^0.27.2", | |||
"react-dom": "^0.14.3", | |||
"react-hot-loader": "^1.3.0", | |||
"react-onclickoutside": "^4.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it should be a dependency and not a dev-dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. I thought since it's small enough, we don't need to increase the number of runtime dependencies and could just bundle it. I can change it if you think it makes a difference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thinks it should be a dependency :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll change it to da dependency while I'm on it.
Should be okay now, please review. |
@frontsideair, I found not only dropdown menu for pagination but also insert row for popup a modal will also use |
No problem, I'll take a look as soon as possible. If there's anyplace else using |
@frontsideair, take your time, currently I just know the insert button for popup modal and the close button in modal. Thanks :) |
Hello there, by now, this library still depends on bootstrap.js and jquery right? |
Removes jQuery and
bootstrap.js
dependencies, but addsreact-onclickoutside
(which is a good tradeoff). I removed those scripts fromexamples/index.html
for good measure.