Skip to content

Add ability to return unselected rows in onSelectAll #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tylerjryan opened this issue May 20, 2016 · 4 comments
Closed

Add ability to return unselected rows in onSelectAll #466

tylerjryan opened this issue May 20, 2016 · 4 comments

Comments

@tylerjryan
Copy link

In the onSelectAll handling, two arguments are passed: isSelected and currentSelectedAndDisplayData. In the case where the user is UN-selecting all, there is currently no way of knowing which rows of the table are being unselected because currentSelectedAndDisplayData is an empty array. This unfortunately makes it impossible to write a handler that is aware of the rows that are being unselected. I do understand that this could be inferred, but there is a particular reason why I need this.

In the case of a single row being unselected, the onSelect callback does pass the row being unselected. Would it be possible to mirror this functionality in the onSelectAll by returning the unselected rows in the callback?

Let me know if this makes sense. Thanks!

@tylerjryan tylerjryan changed the title Add ability to return unselected row keys Add ability to return unselected rows in onSelectAll May 20, 2016
@AllenFang
Copy link
Owner

HI @tylerjryan, sorry for lately reply. I'll thinks about that and maybe released in near future. Thanks 👍

@tylerjryan
Copy link
Author

Great, thank you very much! Nice work on this library!

AllenFang added a commit that referenced this issue May 29, 2016
@AllenFang
Copy link
Owner

Released on v2.3.3, check example. Thanks :)

@tylerjryan
Copy link
Author

Awesome, very glad that you liked the idea, and thank you for implementing
this!

On Sun, May 29, 2016, 08:05 Allen [email protected] wrote:

Released on v2.3.3, check example
https://github.com/AllenFang/react-bootstrap-table/blob/master/examples/js/selection/select-hook-table.js#L34.
Thanks :)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#466 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AEtDPNxHMXYelJGhMHGJsOY-7SWjeMw0ks5qGas3gaJpZM4Ii3fM
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants