Allow latest version of react to be used #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locking in an old version of react means that react needs to be included twice in the bundle If you're using react 15.4.1. Leads to an extra 140 kb of dependencies, more than doubling the size of react-bootstrap-table.
|
@AdeelK93, I wanna to use This is the issue about using So I fork it and lock the version to prevent this error. if you really want the newest react version, you need fix this error first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locking in an old version of react means that react needs to be included twice in the bundle If you're using react 15.4.1. Leads to an extra 140 kb of dependencies, more than doubling the size of react-bootstrap-table.