optimize UTF8 conversion routines #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcodeIO
reviewed
Jan 1, 2020
| if ((u0 & 240) == 224) { | ||
| u0 = (u0 & 15) << 12 | u1 << 6 | u2; | ||
| } else { | ||
| if (bufEnd == bufOff) break; |
There was a problem hiding this comment.
On a first glimpse this seems to be trading branches, like where we previously checked that we can process 3 bytes (never emitting truncated bytes), we now check per byte (potentially emitting truncated bytes?). Makes me wonder what's better.
dcodeIO
reviewed
Jan 10, 2020
MaxGraey
changed the title
MaxGraey
changed the title
dcodeIO
reviewed
Jan 25, 2020
| if (nullTerminated && !c1) break; | ||
| bufLen += 1; strOff += 2; | ||
| // @ts-ignore: cast | ||
| if (nullTerminated & !c1) break; |
There was a problem hiding this comment.
Can also do u32(nullTerminated) & u32(!c1) here to avoid the ts-ignore.
There was a problem hiding this comment.
Yes, and in first version I used exactly that but later we decide just comment with ts ignorance)
There was a problem hiding this comment.
I see, hmm. Do you remember if that was due to wrapping?
dcodeIO
reviewed
Jan 25, 2020
| let u0 = <u32>load<u8>(bufOff); ++bufOff; | ||
| if (!(u0 & 128)) { | ||
| // @ts-ignore: cast | ||
| if (nullTerminated & !u0) break; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.