Skip to content

improve pass pipeline #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Apr 21, 2020
Merged

improve pass pipeline #1227

merged 34 commits into from
Apr 21, 2020

Conversation

MaxGraey
Copy link
Member

No description provided.

@MaxGraey MaxGraey requested a review from dcodeIO April 16, 2020 08:08
@MaxGraey
Copy link
Member Author

MaxGraey commented Apr 16, 2020 •
edited
Loading

Recent commits just attempts to measure optimization speed so don't pay attention

@MaxGraey

This comment has been minimized.

Sign in to view
@jtenner
Copy link
Contributor

jtenner commented Apr 18, 2020

Wow that vacuum pass got rid of a lot.

@MaxGraey
Copy link
Member Author

MaxGraey commented Apr 18, 2020 •
edited
Loading

Nope. vacuum pass just remove nops which could affect to next passes and improve optimization speed. Overall all changes reduce 519 lines

@jtenner
Copy link
Contributor

jtenner commented Apr 18, 2020

Maybe I misread somehow, I was just pointing out there were a lot of removed lines. Looks great.

@MaxGraey MaxGraey mentioned this pull request Apr 20, 2020
Merged
@MaxGraey
Copy link
Member Author

@dcodeIO it's ready for merge

@MaxGraey
Copy link
Member Author

Alright now std/symbol test even reduced

@MaxGraey MaxGraey requested a review from dcodeIO April 21, 2020 12:18
@dcodeIO dcodeIO merged commit f96d3fc into AssemblyScript:master Apr 21, 2020
@MaxGraey MaxGraey deleted the improve-passes branch April 21, 2020 17:55
@MaxMood96 MaxMood96 mentioned this pull request Nov 4, 2022
Open
@ekmixon ekmixon mentioned this pull request Nov 5, 2022
Open
@MaxMood96 MaxMood96 mentioned this pull request Nov 5, 2022
Open
This was referenced Dec 25, 2022
Open
Open
@ekmixon ekmixon mentioned this pull request Dec 26, 2022
Open
This was referenced Jun 22, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO Awaiting requested review from dcodeIO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxGraey @jtenner @dcodeIO