Remember failed globals so we don't hit assertions #1321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to fix #1205 by remembering globals that failed to compile so we properly get a
false
upon subsequentcompileGlobal
invocations and don't run intoassert
s in the first place, as per my latest comment on the above PR.@DuncanUszkay1: Can you confirm that this solves the issue as well?
If so, also fixes #1165
Now also: fixes #1186, fixes #1190