Skip to content

fix: class extends itself #2201 #2266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 23, 2022
Merged

fix: class extends itself #2201 #2266

merged 4 commits into from
Jul 23, 2022

Conversation

technohippy
Copy link
Member

⯈fix: #2201

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

romdotdog
romdotdog reviewed Apr 18, 2022
View reviewed changes
Copy link
Contributor

@romdotdog romdotdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

@dcodeIO
Copy link
Member

dcodeIO commented Apr 23, 2022

I think markVirtuals may not be the ideal place for the check, as it is doing something rather specific at the end of compilation. A better place would be where .base is set in a way that the error condition appears, producing a diagnostic then, so markVirtuals wouldn't need to check?

@technohippy
Copy link
Member Author

@dcodeIO I moved the check to hopefully right place.

@dcodeIO dcodeIO merged commit 1e20054 into AssemblyScript:main Jul 23, 2022
@dcodeIO
Copy link
Member

dcodeIO commented Jul 23, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romdotdog romdotdog romdotdog left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler enters infinite loop when class extends itself
3 participants
@technohippy @dcodeIO @romdotdog