-
-
Notifications
You must be signed in to change notification settings - Fork 669
fix: export default in namespace #2200 #2267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: export default in namespace #2200 #2267
Conversation
As mentioned in the source issue, I think changing the message for this error could be beneficial, wdyt? Do you think it's confusing? cc: @dcodeIO |
I guess the reference to "ECMAScript-style module" can be dropped, as this is all AS supports anyway. Perhaps: "A default export can only be used in a module." Still about the same message, but less over-precise. Another thought: I wonder that a |
I was thinking something more like |
|
I don't think AS supports default exports in |
hmm... I choose |
This reverts commit 5837105.
@dcodeIO Test / Bootstrap throws a strange error now.
|
Only one thing on the logs caught my eye: the newly released |
Fixed the CI error in #2274. Merging main should resolve the error in this PR as well. |
@dcodeIO Thanks. Now all checkes have passed. |
1 similar comment
@dcodeIO Thanks. Now all checkes have passed. |
Thanks! |
⯈fix: #2200
Now the same error message as TS is used.