Skip to content

fix: use correct ctx infer generic types #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2022
Merged

fix: use correct ctx infer generic types #2323

merged 2 commits into from
Jun 23, 2022

Conversation

HerrCai0907
Copy link
Member

⯈Fix #2322
⯈ctxFlow is the flow of caller, but generic type inference need the context of callee

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@trusktr trusktr requested a review from dcodeIO June 14, 2022 16:31
@HerrCai0907
Copy link
Member Author

@dcodeIO Could you have some time to review this PR?

dcodeIO
dcodeIO approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@dcodeIO dcodeIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still wonder why the helper previously wanted a flow, but since it doesn't use it, the change seems good :)

@HerrCai0907
Copy link
Member Author

I still wonder why the helper previously wanted a flow

It is used to lookup the identifier in resolveTypeName

@MaxGraey MaxGraey merged commit 7d93509 into AssemblyScript:main Jun 23, 2022
@HerrCai0907 HerrCai0907 deleted the fix-type-infer-ctx-error branch June 24, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generic Type Infer Failed
3 participants
@HerrCai0907 @dcodeIO @MaxGraey