Skip to content

Fix unreachable in block statement #2325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2022
Merged

Fix unreachable in block statement #2325

merged 2 commits into from
Jun 23, 2022

Conversation

HerrCai0907
Copy link
Member

@HerrCai0907 HerrCai0907 commented Jun 17, 2022 •
edited
Loading

⯈fix #2187
⯈support return unreachable()
⯈avoid compile wat like (return (unreachable)) and then insert shadowstack instrument like (locals.get (unreachable))

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

dcodeIO
dcodeIO reviewed Jun 17, 2022
View reviewed changes
@HerrCai0907 HerrCai0907 force-pushed the fix-unreachable-in-BlockStatement branch 2 times, most recently from c8c1a53 to 70548f5 Compare June 17, 2022 08:36
@HerrCai0907 HerrCai0907 force-pushed the fix-unreachable-in-BlockStatement branch from 70548f5 to 549d72a Compare June 21, 2022 16:40
@MaxGraey MaxGraey merged commit 4ac283a into AssemblyScript:main Jun 23, 2022
@HerrCai0907 HerrCai0907 deleted the fix-unreachable-in-BlockStatement branch June 24, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compiler crash with unreachable in BlockStatement
3 participants
@HerrCai0907 @dcodeIO @MaxGraey