Skip to content

feat: Add overflow detection during parsing integer literals #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jul 20, 2022

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Jul 8, 2022

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@MaxGraey MaxGraey requested a review from dcodeIO July 8, 2022 16:47
@MaxGraey MaxGraey changed the title Add overflow detection during parsing integer literals feat: Add overflow detection during parsing integer literals Jul 8, 2022
@MaxGraey MaxGraey requested a review from dcodeIO July 19, 2022 16:41
Copy link
Member

@dcodeIO dcodeIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't check in full detail, but since the tests pass, I assume that it's good :)

@MaxGraey MaxGraey merged commit 1d05e8d into AssemblyScript:main Jul 20, 2022
@MaxGraey MaxGraey deleted the validate-max-value-for-literals branch July 20, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants