Skip to content

feat: add override keyword #2366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 20, 2022

Conversation

HerrCai0907
Copy link
Member

fix: #2353
add override keyword and type check

support following code

class A {
  method(): void {}
}
class B extends A {
  override method(): void {}
  // This member cannot have an 'override' modifier because it is not declared in the base class 'A'.
  override method_error(): void {}
}
  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@HerrCai0907 HerrCai0907 requested a review from dcodeIO July 10, 2022 15:40
@MaxGraey MaxGraey merged commit 9cbb728 into AssemblyScript:main Jul 20, 2022
@MaxGraey
Copy link
Member

Thanks!

@HerrCai0907 HerrCai0907 deleted the feat/add-override-keyword branch July 22, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not support override keyword
2 participants