Skip to content

[cli] Prevent uses binaryFile in options #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

MaxGraey
Copy link
Member

It's pretty frequent mistake during migration from 0.19.x to 0.20.x.

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@MaxGraey MaxGraey requested a review from dcodeIO July 22, 2022 08:27
@MaxGraey MaxGraey added enhancement tooling compatibility dependencies Pull requests that update a dependency file labels Jul 22, 2022
@MaxGraey MaxGraey merged commit c6b4e84 into AssemblyScript:main Aug 15, 2022
@MaxGraey MaxGraey deleted the warn-for-binaryFile branch August 15, 2022 18:13
@@ -855,6 +855,10 @@ export async function main(argv, options) {

// Prepare output
if (!opts.noEmit) {
if (opts.binaryFile) {
// We catched lagacy field for binary output (before 0.20)
return prepareResult(Error("`binaryFile` doesn't support. Please use `outFile` instead."));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps

Usage of the --binaryFile compiler option is no longer supported. Use --outFile instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility dependencies Pull requests that update a dependency file enhancement tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants