Skip to content

Fix: multi implements issue #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 6, 2022
Merged

Fix: multi implements issue #2510

merged 11 commits into from
Oct 6, 2022

Conversation

JesseCodeBones
Copy link
Contributor

From issue 2508

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@JesseCodeBones JesseCodeBones mentioned this pull request Sep 21, 2022
Merged
2 tasks
@dcodeIO dcodeIO mentioned this pull request Sep 25, 2022
Merged
2 tasks
dcodeIO
dcodeIO reviewed Sep 27, 2022
View reviewed changes
Copy link
Member

@dcodeIO dcodeIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look at the branch, and made a couple changes (remember to git pull on your end). A few observations below. I think with those addressed the PR can be merged, even though it then does not cover all cases.

@dcodeIO dcodeIO merged commit 3afcce8 into AssemblyScript:main Oct 6, 2022
@dcodeIO
Copy link
Member

dcodeIO commented Oct 6, 2022

Thanks!

@JesseCodeBones JesseCodeBones deleted the issue-2508 branch October 6, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JesseCodeBones @dcodeIO