Improve Signature lookups, Make Signature immutable #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on being is because signature type lookups have become a big bottleneck for libraries that have a lot of type signatures. We can uniquely identify these signatures by calculating their string representation using signature.toString(). This causes a lot of not so very straightforward problems within the compiler, the program, and the resolver. For instance, the compiler now has to call the `newStub` function with the maximum arguments, and when resolving a type in the resolver, we are not allowed to simply modify the return type of signatures, and instead we create a new one to obtain the proper function type id at instantiation time. Changes involved: - compiler tests fixtures updated - Signatures are now immutable - Some changes involving signatureReference equality have changed
|
After some local testing, I got some really amazing speed increases. I tested nearly 250k function signatures in that list, and the time it took to deal with them reduced to thirty seconds instead of a whopping 25 minutes (or more.) This can be regarded as a generalized improvement. |
dcodeIO
reviewed
Dec 1, 2022
Remove comments Co-authored-by: dcode <[email protected]>
CountBleck
requested changes
Dec 5, 2022
src/resolver.ts
Outdated
| let signature = new Signature(this.program, parameterTypes, returnType, thisType); | ||
| signature.requiredParameters = requiredParameters; | ||
| signature.hasRest = hasRest; | ||
| let signature = Signature.new(this.program, parameterTypes, returnType, thisType, requiredParameters, hasRest); |
There was a problem hiding this comment.
Suggested change
| let signature = Signature.new(this.program, parameterTypes, returnType, thisType, requiredParameters, hasRest); | |
| let signature = Signature.create(this.program, parameterTypes, returnType, thisType, requiredParameters, hasRest); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, the Signature class becomes immutable. The reason being is because signature type lookups have become a big bottleneck for libraries that have a lot of type signatures. We can uniquely identify these signatures by calculating their string representation using signature.toString(). This causes a lot of not so very straightforward problems within the compiler, the program, and the resolver. For instance, the compiler now has to call the
newStubfunction with the maximum arguments, and when resolving a type in the resolver, we are not allowed to simply modify the return type of signatures, and instead we create a new one to obtain the proper function type id at instantiation time.Changes involved:
⯈
⯈
⯈