Remove unchecked indexed set on normal arrays #2586
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turned up in #2575, where if
--uncheckedBehavior always
is given, anarray[index] = ...
, when setting anindex >= length
, does not ensure that the array has enough capacity. Code might however expect that this basic contract holds regardless. Hence this PR removes unchecked indexed set on normal arrays. Does not change fixed sized arrays, where there is no such side-effect to retain.