Skip to content

Remove unchecked indexed set on normal arrays #2586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Dec 6, 2022

Turned up in #2575, where if --uncheckedBehavior always is given, an array[index] = ..., when setting an index >= length, does not ensure that the array has enough capacity. Code might however expect that this basic contract holds regardless. Hence this PR removes unchecked indexed set on normal arrays. Does not change fixed sized arrays, where there is no such side-effect to retain.

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant