Skip to content

Make WebSocketUpgradeHandler extensible in a controlled manner. #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2017
Merged

Conversation

thabach
Copy link
Contributor

@thabach thabach commented Aug 2, 2017

Via protected template methods, make WebSocketUpgradeHandler extensible in a controlled manner.

@slandelle slandelle merged commit d66e588 into AsyncHttpClient:master Aug 2, 2017
@slandelle slandelle added this to the 2.0.34 milestone Aug 2, 2017
@slandelle slandelle self-assigned this Aug 2, 2017
@slandelle
Copy link
Contributor

I probably won't be able to release before a few days.
Please ping if I forget.

@seamusmac
Copy link

@thabach @slandelle Thanks for this, will try to get wasync using this asap. No rush on release yet :)

@seamusmac
Copy link

There is one method setWebSocket, that I was overriding too, so I could grab an instance and use in the extension. Can we add that too?

@jfarcand
Copy link
Contributor

jfarcand commented Aug 2, 2017

@slandelle Merci :-)

@slandelle
Copy link
Contributor

@seamusmac Go ahead.

@jfarcand De rien ;-)

@thabach
Copy link
Contributor Author

thabach commented Aug 2, 2017

@slandelle please merge #1447 - cheers !

slandelle pushed a commit that referenced this pull request Aug 3, 2017
@slandelle slandelle modified the milestones: 2.1.0, 2.0.34 Aug 3, 2017
@slandelle
Copy link
Contributor

@thabach done

slandelle pushed a commit that referenced this pull request Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants