Bump netty to 4.1.60.Final #1775 #1782
Conversation
hysterus1
force-pushed
the
bump-netty-to-4-1-60
branch
2 times, most recently
from
67e05e8 to
2c919d3
Compare
X-Duplicated-Header as Netty added normalization against the Content-Length header
hysterus1
force-pushed
the
bump-netty-to-4-1-60
branch
from
2c919d3 to
52afb50
Compare
|
Netty has added special normalization and validation for the Content-Length header. In case the headers are duplicated, the receiver should either reject the response or only pick and parse the correct header entry. Long story short, with newest Netty one can't have this header duplicated. That is not a big problem for async-http-client, as the old behavior was only relied on in the tests. I've adjusted the tests to simply use a different header instead. |
|
I will wait for the build to pass and then squash the commits. |
|
@hysterus1 Note that that CircleCI build passed, but the GitHub Actions one failed. Ran this locally and this passed too - GH had a few timeouts issues in the past due to (what I think is) the amount of "power" each allocated test agent gets (CPU, RAM, etc...). Merged. |
Hello, I'm kindly asking to treat this PR with high priority as it involves security of the library. #1775