Skip to content

Use uv managed python in GHA workflows #2342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

eifinger
Copy link
Contributor

@eifinger eifinger commented Feb 9, 2025

Purpose

Less overhead makes this easier to maintain and enables using hardlinking on Windows runners

The hardlinking warning can be seen here.
https://github.com/Azure-Samples/azure-search-openai-demo/actions/runs/13211586770/job/36885643258
grafik

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[x] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[x] No

Type of change

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff and black manually on my code.

Less overhead makes this easier to maintain and enables using hardlinking on Windows runners
@eifinger
Copy link
Contributor Author

eifinger commented Feb 9, 2025

@microsoft-github-policy-service agree

Copy link
Collaborator

@pamelafox pamelafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good, but I'd like to get the CI to run to verify it before merging.

@pamelafox
Copy link
Collaborator

Not sure how to get the CI to run here, has this run on your own fork successfully?

@eifinger
Copy link
Contributor Author

Not sure how to get the CI to run here, has this run on your own fork successfully?

I removed the line that filtered out PR triggers for changes to workflow files. I tested this PR successfully in this run: https://github.com/eifinger/azure-search-openai-demo/actions/runs/13228783804

@pamelafox
Copy link
Collaborator

Great, merging!

@pamelafox pamelafox merged commit a54e8eb into Azure-Samples:main Feb 10, 2025
1 check passed
dfl-aeb pushed a commit to dfl-aeb/azure-search-openai-demo that referenced this pull request Feb 19, 2025
Less overhead makes this easier to maintain and enables using hardlinking on Windows runners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants