Skip to content

Upgrade ms graph SDK packages to remove pendulum dependency #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

pamelafox
Copy link
Collaborator

Purpose

Fixes #2423
Fixes #2384

Many developers are getting pip install errors in Python 3.13, especially on Windows, due to missing wheel for pendulum package. The most recent version of SDK doesn't need pendulum, so let's try updating the package. Code changes may be needed as well, I will run the auth code to check.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[ ] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[ ] No

Type of change

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff and black manually on my code.

@pamelafox pamelafox marked this pull request as ready for review March 27, 2025 04:45
# pip-compile requirements.in
#
# This file was autogenerated by uv via the following command:
# uv pip compile requirements.in -o requirements.txt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pip was unable to resolve the dependencies, uv had no problems and was super fast. So we can use uv to compile, and you can still use pip to install.

@pamelafox pamelafox merged commit c5bfb22 into Azure-Samples:main Mar 27, 2025
11 checks passed
@pamelafox pamelafox deleted the msgraphupgrade branch March 27, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error running ./app/start.ps1 Some packages don't have 3.13 wheels yet and require cargo compilation
2 participants