Change management sdk to tack2 #5
Conversation
|
@nickzhums - Can you please review? |
|
@yungezz @weidongxu-microsoft @xccc-msft @ChenTanyi |
|
overall looks good to me |
| <groupId>com.microsoft.azure</groupId> | ||
| <artifactId>azure</artifactId> | ||
| <version>1.36.3</version> | ||
| <groupId>com.azure.resourcemanager</groupId> |
There was a problem hiding this comment.
maybe mention that this will be replaced when the stable version is available
| import okhttp3.OkHttpClient; | ||
| import okhttp3.Request; | ||
| import org.apache.commons.lang3.StringUtils; | ||
| import com.azure.core.annotation.BodyParam; |
There was a problem hiding this comment.
is it necessary to change sample package name also for consistency? Sample package names has no impact to user actually, just for clearness. @xccc-msft @weidongxu-microsoft what's your thinking? what's package name of our generated samples?
There was a problem hiding this comment.
For now we only updated GA samples. As SQL is still in preview, we didn't update this repo before. For the updated repo like Azure-Samples/storage-java-manage-storage-accounts, the package name would be updated for consistency.
Change management sdk to tack2
@jongio for notification