Support optional path parameter for Modular #3152

v-jiaodi · 2025-04-03T02:04:26Z

upgrade to tcgc dev.3
support optional path parameter

…nto monitor-nightly43

MaryGao · 2025-04-22T02:37:05Z

packages/typespec-test/test/authoring/generated/openapi/2022-05-15-preview/openapi.json

@@ -930,7 +930,7 @@
    },
    "Azure.Core.Foundations.InnerError": {
      "type": "object",
-      "description": "An object containing more specific information about the error. As per Microsoft One API guidelines - https://github.com/Microsoft/api-guidelines/blob/vNext/Guidelines.md#7102-error-condition-responses.",
+      "description": "An object containing more specific information about the error. As per Microsoft One API guidelines - https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md#handling-errors.",


@jiaodi could you help investigate why this appears?

refer to: https://github.com/Azure/typespec-azure/pull/2512/files

…est.typescript into monitor-nightly43

packages/typespec-test/package.json

packages/typespec-ts/test/azureModularIntegration/pathParameters.spec.ts

…rs.spec.ts

packages/typespec-ts/test/azureModularIntegration/pathParameters.spec.ts

…rs.spec.ts

MaryGao · 2025-04-27T08:57:13Z

packages/typespec-ts/test/modularUnit/scenarios/classicClient/classicClient.md

@@ -25,6 +25,8 @@ enum Versions {
  @useDependency(Azure.Core.Versions.v1_0_Preview_2)
  `2022-08-30`,
 }
+
+op foo(): void;


No operations would lead to no client and model only case. So we can't verify the client name change so add one op here. Could you create an issue to support empty model generation for modular I think we could verify once tcgc has the case?

…est.typescript into monitor-nightly43

packages/typespec-ts/test/modularUnit/scenarios/operations/emptyOperation.md

MaryGao · 2025-04-28T05:31:30Z

packages/typespec-ts/test/azureIntegration/azureCorePage.spec.ts

@@ -41,6 +41,7 @@ describe("Azure Core Page Rest Client", () => {
      .post({
        body: validBody,
        queryParameters: {
+          "api-version": "2022-12-01-preview",


new change?

qiaozha · 2025-04-28T06:36:10Z

packages/typespec-ts/test/modularUnit/scenarios/operations/pathParam/optionalPath.md

+This is tsp definition.
+
+```tsp
+op read(@path param?: string): OkResponse;


does optional path params work in RLC?

issue tracked #3178

v-jiaodi and others added 7 commits April 3, 2025 10:03

update package to next

0e4ed89

Merge branch 'main' of https://github.com/Azure/autorest.typescript i…

f1aaee0

…nto monitor-nightly43

Merge branch 'main' into monitor-nightly43

3911246

Merge branch 'main' of https://github.com/Azure/autorest.typescript i…

7c0e9b8

…nto monitor-nightly43

regen

6fc79bf

Merge branch 'main' of https://github.com/Azure/autorest.typescript i…

d827904

…nto monitor-nightly43

Merge branch 'main' into monitor-nightly43

45750c1

qiaozha assigned MaryGao Apr 18, 2025

MaryGao and others added 4 commits April 21, 2025 09:59

Merge branch 'main' into monitor-nightly43

199949a

update

8b593ec

revert

11dd719

regen smoke

5410a17

This comment was marked as off-topic.

Sign in to view

MaryGao reviewed Apr 22, 2025

View reviewed changes

MaryGao and others added 6 commits April 22, 2025 13:29

Fix the empty client issue

c44ea2e

skip case

edcabfc

Merge branch 'monitor-nightly43' of https://github.com/v-jiaodi/autor…

1d68200

…est.typescript into monitor-nightly43

regen code

193aa74

update

0d97ec9

update case

acce792

MaryGao changed the title ~~Monitor nightly CI~~ Support optional path parameter for Modular Apr 27, 2025

MaryGao and others added 2 commits April 27, 2025 13:55

Merge branch 'main' into monitor-nightly43

c360fb0

update package version

2bf1c3c

MaryGao reviewed Apr 27, 2025

View reviewed changes

packages/typespec-test/package.json Outdated Show resolved Hide resolved

v-jiaodi added 3 commits April 27, 2025 14:33

use latest dev for tcgc

fe278ea

update package version

8e13496

Merge branch 'main' into monitor-nightly43

648771b

MaryGao reviewed Apr 27, 2025

View reviewed changes

packages/typespec-test/package.json Show resolved Hide resolved

MaryGao added 2 commits April 27, 2025 15:42

Upgrade to dev 3 version for tcgc to support optional path parameter

b952833

Add test cases for optional path and remove useless codes

fc7b4c8

MaryGao and others added 4 commits April 27, 2025 15:55

Format codes

398e84a

add test case for path

b2189b4

format

9e0c260

update

f34479a

MaryGao reviewed Apr 27, 2025

View reviewed changes

packages/typespec-ts/test/azureModularIntegration/pathParameters.spec.ts Outdated Show resolved Hide resolved

Update packages/typespec-ts/test/azureModularIntegration/pathParamete…

b74e6b6

…rs.spec.ts

MaryGao reviewed Apr 27, 2025

View reviewed changes

packages/typespec-ts/test/azureModularIntegration/pathParameters.spec.ts Outdated Show resolved Hide resolved

Update packages/typespec-ts/test/azureModularIntegration/pathParamete…

e8b9903

…rs.spec.ts

MaryGao reviewed Apr 27, 2025

View reviewed changes

v-jiaodi mentioned this pull request Apr 27, 2025

Models are not exported to top-level index for model only case #3177

Open

v-jiaodi added 2 commits April 27, 2025 18:02

add ut

c9a4eff

Merge branch 'monitor-nightly43' of https://github.com/v-jiaodi/autor…

9d072f0

…est.typescript into monitor-nightly43

MaryGao reviewed Apr 27, 2025

View reviewed changes

packages/typespec-ts/test/modularUnit/scenarios/operations/emptyOperation.md Outdated Show resolved Hide resolved

update case

50013b4

MaryGao marked this pull request as ready for review April 28, 2025 03:34

MaryGao requested review from joheredi and qiaozha as code owners April 28, 2025 03:34

MaryGao added 2 commits April 28, 2025 13:16

Remove the case

e26c82d

Remove useless parameter

0f7d5a1

MaryGao reviewed Apr 28, 2025

View reviewed changes

MaryGao approved these changes Apr 28, 2025

View reviewed changes

qiaozha reviewed Apr 28, 2025

View reviewed changes

fix ci

602b213

qiaozha approved these changes Apr 28, 2025

View reviewed changes

MaryGao merged commit 3d01423 into Azure:main Apr 28, 2025
17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support optional path parameter for Modular #3152

Support optional path parameter for Modular #3152

v-jiaodi commented Apr 3, 2025 •

edited by MaryGao

Loading

This comment was marked as off-topic.

MaryGao Apr 22, 2025

v-jiaodi Apr 22, 2025

MaryGao Apr 27, 2025 •

edited

Loading

v-jiaodi Apr 27, 2025

MaryGao Apr 28, 2025

qiaozha Apr 28, 2025

MaryGao Apr 28, 2025

Support optional path parameter for Modular #3152

Support optional path parameter for Modular #3152

Conversation

v-jiaodi commented Apr 3, 2025 • edited by MaryGao Loading

This comment was marked as off-topic.

MaryGao Apr 22, 2025

Choose a reason for hiding this comment

v-jiaodi Apr 22, 2025

Choose a reason for hiding this comment

MaryGao Apr 27, 2025 • edited Loading

Choose a reason for hiding this comment

v-jiaodi Apr 27, 2025

Choose a reason for hiding this comment

MaryGao Apr 28, 2025

Choose a reason for hiding this comment

qiaozha Apr 28, 2025

Choose a reason for hiding this comment

MaryGao Apr 28, 2025

Choose a reason for hiding this comment

v-jiaodi commented Apr 3, 2025 •

edited by MaryGao

Loading

MaryGao Apr 27, 2025 •

edited

Loading