Templating Dockerfiles - NODE/PYTHON #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CooperLink
requested review from
ahmelsayed,
anirudhgarg,
balag0,
divyagandhisethi,
pragnagopa and
vrdmr
as code owners
added 2 commits
November 5, 2021 12:15
|
Need to understand why /out/ was not .gitignored and delete those files from this pull |
pragnagopa
reviewed
Nov 5, 2021
| ARG HOST_VERSION | ||
|
|
||
| ENV PublishWithAspNetCoreTargetManifest=false | ||
| ENV DEBIAN_FRONTEND=noninteractive |
There was a problem hiding this comment.
delete changes in Java files? PR should be scoped to Node / Python
There was a problem hiding this comment.
Yes, this is related to the thing I mentioned before. For whatever reason, git did not follow the gitignore file that I added in the last PR. These out/ files should not be pushed
pragnagopa
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DO NOT MERGE] PR for tracking ... still templating/testing python
Follow up PR for #516 to bring changes to node and python images.
Testing in progress for Python images. Node has been tested.
PR information