Add CustomStatus Size Check for OOP model #3113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgillum
reviewed
May 20, 2025
src/WebJobs.Extensions.DurableTask/ContextImplementations/RemoteOrchestratorContext.cs
Outdated
Show resolved
Hide resolved
bachuv
reviewed
May 21, 2025
src/WebJobs.Extensions.DurableTask/ContextImplementations/RemoteOrchestratorContext.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Extensions.DurableTask/ContextImplementations/RemoteOrchestratorContext.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Extensions.DurableTask/ContextImplementations/RemoteOrchestratorContext.cs
Outdated
Show resolved
Hide resolved
AnatoliB
reviewed
May 23, 2025
| // Azure Table Storage enforces a 32 KB limit if a property value is a UTF-16 encoded string. | ||
| // We apply a 16 KB limit here to align with our in-process model. | ||
| const int MaxCustomStatusSizeInKB = 16; | ||
| double customStatusSizeInKB = customStatus != null ? Encoding.Unicode.GetByteCount(customStatus) / 1024.0 : 0; |
There was a problem hiding this comment.
Not a big deal, but do we really need floating-point computation here? Consider defining the constant as 16*1024 and just comparing it with the GetByteCount result. This may be more performant (though the impact is probably negligible) but, more importantly, this will eliminate some mental overhead for the reader of this code.
There was a problem hiding this comment.
Thanks for the review, Anatoli! This was changed like this because of this comment .
cgillum
approved these changes
May 23, 2025
src/WebJobs.Extensions.DurableTask/ContextImplementations/RemoteOrchestratorContext.cs
Outdated
Show resolved
Hide resolved
bachuv
approved these changes
May 23, 2025
bachuv
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2918
Azure Storage has limit on Table Property, which is 64KB. For string value and UTF16 encoded, it should be 32 KB or less. Larger value will cause error.
This PR adds a
CustomStatussize check, so that when it's too large, fail the orchestration instead. The limit size is 16KB with UTF16 encoded to align with in-process model.Pull request checklist
pending_docs.mdrelease_notes.md/src/Worker.Extensions.DurableTask/AssemblyInfo.csdevandmainbranches and will not be merged into thev2.xbranch.