Skip to content

Worker dependencies must be shaded (package renamed) to avoid dependency collision #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tetradeus opened this issue Jan 8, 2020 · 1 comment · Fixed by #379
Closed

Comments

@Tetradeus
Copy link

Looking at this https://github.com/Azure/azure-functions-java-worker/wiki/Azure-Java-Functions-Worker-Dependencies, couldn't you shade common libraries in order to avoid dependency collision and runtime issue ?

I am talking about guava, netty, apache commons, ...

Right now, it is very difficult to understand why a function is failing when it happens.

I tried to use azure storage java sdk v 12.1.0 (last version) and because of a collision with netty it just could not work (Luckily the sdk provides a way to also use the okhttp client else I would have been stuck)

@amamounelsayed
Copy link
Contributor

@Tetradeus We are working on shading the netty jar in the next release. We will be working on the next libraries next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants