Feature/shadding

[amamounelsayed]

This feature is for shading all worker jars.

Only for JAVA 8
To be a backward compatible I freeze all the jars we currently have added to repo.
Then when we load the classloader we will load the worker lib first then customer.

If the user like to reverse this order and their jars takes presence first, they will need to add FUNCTIONS_WORKER_JAVA_LOAD_APP_LIBS True or 1. By this way it will be opt-in scenario.

JAVA 11 will use only the customer jars.

Generated jar after shading:
azure-functions-java-worker.zip

Fixes #340, Fixes #183, Fixes #373, Fixes #368, Fixes #365, Fixes #341

[pragnagopa]

Thanks! Added few comments.

[TsuyoshiUshio]

I reviewed the PR. Could you have a look?

[pragnagopa]

LGTM. Added more comments. Please wait for sign off from @TsuyoshiUshio as well.

[pragnagopa]

One more question: instead of checking in individual jars, is it possible to ship one jar file?

[amamounelsayed]

One more question: instead of checking in individual jars, is it possible to ship one jar file?

Got it, this may add more complication to the jar loading. I can have a look but this approach is just temporary solution.

[pragnagopa]

I am sorry did not get the question.

This PR includes individual jar files in folder lib_worker_1.6.2, can we combine them into one jar file: libWorker1.6.2.jar : https://stackoverflow.com/questions/5080220/how-to-combine-two-jar-files

[amamounelsayed]

This PR includes individual jar files in folder lib_worker_1.6.2, can we combine them into one jar file: libWorker1.6.2.jar : https://stackoverflow.com/questions/5080220/how-to-combine-two-jar-files

Got it, this may add more complication to the jar loading. I can have a look but this approach is just temporary solution.

[pragnagopa]

Got it, this may add more complication to the jar loading. I can have a look but this approach is just temporary solution.

I missed mentioning this before, can you please update PR description with size of the java worker folder with this change? If it is significantly higher, it is worth combining jars and checking the size. Due to size restrictions on windows VMs, we need to ensure worker size does not change much with this change.

[amamounelsayed]

I missed mentioning this before, can you please update PR description with size of the java worker folder with this change? If it is significantly higher, it is worth combining jars and checking the size. Due to size restrictions on windows VMs, we need to ensure worker size does not change much with this change.

The nuget will be increased by around 12MB.

[pragnagopa]

The nuget will be increased by around 12MB.

Thanks. Not a blocker then!

[pragnagopa]

Does this PR address: ##340 and #183 ?

[amamounelsayed]

Thank you so much @pragnagopa for your time.

Does this PR address: ##340 and #183 ?

Yeap this is correct also
#373
#368
#365
#341

[pragnagopa]

Updated the description to include references to issues to ensure merging PR closed all of them.

[TsuyoshiUshio]

LGTM

[TsuyoshiUshio]

LGTM