Skip to content

Issue/565/skilltrigger returnval #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

ahmedmuhsin
Copy link
Contributor

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Summary:
Introduced hasNonVoidReturnType and hasEffectiveReturnType methods to streamline return type checks and implicit output handling. Updated relevant logic in BindingDataStore, MethodBindInfo, and ParameterResolver to enhance clarity and maintainability.

Key Changes:

  1. Added hasNonVoidReturnType to identify non-void return types.
  2. Added hasEffectiveReturnType to handle return types and implicit outputs.
  3. Updated ParameterResolver to use hasEffectiveReturnType.
  4. Enhanced test coverage for new logic in ParameterResolverTest.

@ahmedmuhsin ahmedmuhsin merged commit 70d2fa5 into Azure:dev Nov 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants