update docs to add Consumption plan support related link. #1172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaddyDev
requested review from
Charles-Gagnon,
chlafreniere and
VasuBhog
as code owners
| @@ -173,6 +173,9 @@ There are two types of scaling available: | |||
|
|
|||
| For more information, check documentation on [Runtime Scaling](https://learn.microsoft.com/azure/azure-functions/event-driven-scaling#runtime-scaling). You can configure scaling parameters by going to 'Scale out (App Service plan)' setting on the function app's page. To understand various scale settings, please check the respective sections in [Azure Functions Premium plan](https://learn.microsoft.com/azure/azure-functions/functions-premium-plan?tabs=portal#eliminate-cold-starts)'s documentation. | |||
|
|
|||
| For information on setup and configuration details, see the [overview](https://learn.microsoft.com/azure/azure-functions/functions-bindings-azure-sql). | |||
| The Azure SQL trigger scaling decisions for the Consumption and Premium plans are done via target-based scaling. For more information, see [Target-based scaling](https://learn.microsoft.com/azure/azure-functions/functions-target-based-scaling). | |||
There was a problem hiding this comment.
Maybe move this second sentence up into the "Target Based Scaling" section? Bit easier to follow that way IMO
| @@ -173,6 +173,9 @@ There are two types of scaling available: | |||
|
|
|||
| For more information, check documentation on [Runtime Scaling](https://learn.microsoft.com/azure/azure-functions/event-driven-scaling#runtime-scaling). You can configure scaling parameters by going to 'Scale out (App Service plan)' setting on the function app's page. To understand various scale settings, please check the respective sections in [Azure Functions Premium plan](https://learn.microsoft.com/azure/azure-functions/functions-premium-plan?tabs=portal#eliminate-cold-starts)'s documentation. | |||
|
|
|||
| For information on setup and configuration details, see the [overview](https://learn.microsoft.com/azure/azure-functions/functions-bindings-azure-sql). | |||
There was a problem hiding this comment.
Why are you adding a link to that page here? I don't even see anything about scaling on that page - would https://learn.microsoft.com/en-us/azure/azure-functions/functions-bindings-azure-sql-trigger?pivots=programming-language-csharp&tabs=isolated-process%2Cpython-v2%2Cportal#enable-runtime-driven-scaling be better to link to instead?
But even that seems to be mostly a duplicate of what we have here already, so I'm not sure what benefit it provides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated our repo docs section to add a link referring to info on consumption plan.
Ramya and Brain will update the learn docs to reflect the same on the Target Scaling page and we already have this on our learn docs: