Skip to content

Updated Linux and ARM release tags #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2017

Conversation

digimaun
Copy link
Member

Checklist

  • I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-python/blob/master/.github/CONTRIBUTING.md).

  • I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
    I have rerun the release scripts. No tests failed.

  • If this is a modification that impacts the behavior of a public API

    • I edited the corresponding document in the devdoc folder and added or modified requirements.
  • I submitted this PR against the correct branch: I am not sure what the current dev branch is!

    • [] This pull-request is submitted against the master branch.

Reference/Link to the issue solved with this PR (if any)

Description of the problem

Existing platform architecture tags are not compliant with PEP513. Also there is no specifier for ARM like for Raspberry Pi.

Description of the solution

Small tweak to the Release.sh script with correct identifiers as specified by
https://www.python.org/dev/peps/pep-0513/ (for Linux)

and future state (for arm)
pypi/warehouse#2003

Presently Pypi accepts the manylinux1_....

@msftclas
Copy link

@digimaun,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@zolvarga
Copy link
Contributor

Hi Paymaun,

Please remove the service/src/iothub_service_client_python.cpp changes from the PR.
Our release process will maintain the version number of the Python SDK. We should not change it directly.

Thanks,
Zoltan

@digimaun
Copy link
Member Author

Might there be a better branch to submit a pull request against? Like a current dev branch? The .cpp version change was actually from a different author - not from the changes I would like to submit.

Thank You,
Paymaun

@zolvarga zolvarga merged commit 56be3b8 into Azure:release_python_2017_06_16 Jun 26, 2017
pierreca pushed a commit that referenced this pull request Aug 28, 2019
)

* Added TestDox support

* Refactored some tests to adjust output

* Added some missing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants