This repository was archived by the owner on Jan 27, 2021. It is now read-only.
Not cutting the minion name when displaying it if it's an IPv4 address #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and not a hostnamewq
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes a minion is represented by IP and not by hostname.
In that case, cutting it to till the first '.' appears as it is done today results with unclear and confusing displayed name (for example, 127.0.0.1 is displayed as 127). Hence, the patch adds logic to check whether the minion name is a hostname or an IP, and if it's an IP - display it 'as is'.
Note - IPv6 handling is NOT part of this patch.