[CosmosDB] Add breaking change notification for list connection string output change #24108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.CosmosDB
️✔️Az.KeyVault
️✔️Az.Network
️✔️Az.Resources
|
ghost
mentioned this pull request
6 tasks
ghost
changed the title
msJinLei
requested changes
Feb 6, 2024
|
|
||
| namespace Microsoft.Azure.Commands.CosmosDB | ||
| { | ||
| [GenericBreakingChange("Output type for -Type ConnectionStrings will be changed to List<DatabaseAccountConnectionString> in next major version.")] |
There was a problem hiding this comment.
'GenericBreakingChangeAttribute' is obsolete: 'This attribute is deprecated. Please use GenericBreakingChangeWithVersionAttribute instead
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
ghost
requested a review
from
msJinLei
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We made changes in our 2023-03-15 Cosmos DB RP API version to update the format that our ListConnectionStrings returns. At that time, we were advised that it was a breaking change and needed an advanced notification, so closed the original PR here: #22829
This adds the breaking change notification separately so that we can introduce this change in the next breaking change release.
Here is the new PR for the breaking changes themselves: #24109
Mandatory Checklist
Please choose the target release of Azure PowerShell
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.