Skip to content

Migrate Fleet from generation to release-2024-04-02 #24522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

azure-powershell-bot
Copy link
Collaborator

Description

Migrate Fleet from generation to release-2024-04-02
The last commit of src/Fleet in generation is:
commit 187b7fe Author: JoyerJin [email protected] Date: Sat Mar 23 11:35:13 2024 +0800 Revert MI breaking changes for Fleet (#24448)

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Mar 26, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.Fleet
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzFleet Get-AzFleet Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzFleet Get-AzFleet changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzFleetMember Get-AzFleetMember Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzFleetMember Get-AzFleetMember changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzFleetUpdateRun Get-AzFleetUpdateRun Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzFleetUpdateRun Get-AzFleetUpdateRun changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzFleetUpdateStrategy Get-AzFleetUpdateStrategy Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzFleetUpdateStrategy Get-AzFleetUpdateStrategy changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzFleetUpdateGroupObject New-AzFleetUpdateGroupObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzFleetUpdateStageObject New-AzFleetUpdateStageObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzFleet Get-AzFleet Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzFleet Get-AzFleet changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzFleetMember Get-AzFleetMember Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzFleetMember Get-AzFleetMember changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzFleetUpdateRun Get-AzFleetUpdateRun Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzFleetUpdateRun Get-AzFleetUpdateRun changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzFleetUpdateStrategy Get-AzFleetUpdateStrategy Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzFleetUpdateStrategy Get-AzFleetUpdateStrategy changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzFleetUpdateGroupObject New-AzFleetUpdateGroupObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzFleetUpdateStageObject New-AzFleetUpdateStageObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ New-AzFleetUpdateStrategy 2 3 Mismatched_Parameter_Value_Type New-AzFleetUpdateStrategy -FleetInputObject $f is not an expected parameter value type. -FleetInputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleetIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleet.(Command).
⚠️ Remove-AzFleet 2 2 Mismatched_Parameter_Value_Type Remove-AzFleet -InputObject $f is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleetIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleet.(Command).
⚠️ Remove-AzFleetMember 2 2 Mismatched_Parameter_Value_Type Remove-AzFleetMember -InputObject $m is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleetIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleetMember.(Command).
⚠️ Remove-AzFleetUpdateStrategy 1 2 Mismatched_Parameter_Value_Type Remove-AzFleetUpdateStrategy -FleetInputObject $f is not an expected parameter value type. -FleetInputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleetIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleet.(Command).
⚠️ Update-AzFleetMember 2 2 Mismatched_Parameter_Value_Type Update-AzFleetMember -InputObject $member is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleetIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleetMember.(Command).
⚠️ Update-AzFleetUpdateStrategy 1 3 Mismatched_Parameter_Value_Type Update-AzFleetUpdateStrategy -FleetInputObject $f is not an expected parameter value type. -FleetInputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleetIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleet.(Command).
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ New-AzFleetUpdateStrategy 2 3 Mismatched_Parameter_Value_Type New-AzFleetUpdateStrategy -FleetInputObject $f is not an expected parameter value type. -FleetInputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleetIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleet.(Command).
⚠️ Remove-AzFleet 2 2 Mismatched_Parameter_Value_Type Remove-AzFleet -InputObject $f is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleetIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleet.(Command).
⚠️ Remove-AzFleetMember 2 2 Mismatched_Parameter_Value_Type Remove-AzFleetMember -InputObject $m is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleetIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleetMember.(Command).
⚠️ Remove-AzFleetUpdateStrategy 1 2 Mismatched_Parameter_Value_Type Remove-AzFleetUpdateStrategy -FleetInputObject $f is not an expected parameter value type. -FleetInputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleetIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleet.(Command).
⚠️ Update-AzFleetMember 2 2 Mismatched_Parameter_Value_Type Update-AzFleetMember -InputObject $member is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleetIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleetMember.(Command).
⚠️ Update-AzFleetUpdateStrategy 1 3 Mismatched_Parameter_Value_Type Update-AzFleetUpdateStrategy -FleetInputObject $f is not an expected parameter value type. -FleetInputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleetIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.Fleet.Models.IFleet.(Command).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Fleet. Add a changelog record under Upcoming Release section with past tense.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Fleet. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@vidai-msft vidai-msft merged commit b8bbd74 into release-2024-04-02 Mar 27, 2024
@wyunchi-ms wyunchi-ms deleted the codegen/Fleet branch April 23, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants