Removed Reason from CheckNameAvailability_Available.json in DeviceUpdate #13914

abatishchev · 2021-04-13T20:23:35Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

abatishchev · 2021-04-13T20:46:05Z

/azp run

openapi-pipeline-app · 2021-04-13T20:46:08Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-04-13T20:46:09Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 3d15327. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/deviceupdate/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.DeviceUpdate [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.DeviceUpdate.1.0.1-beta.1.nupkg
- Microsoft.Azure.Management.DeviceUpdate.1.0.1-beta.1.snupkg

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 3d15327. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/deviceupdate/mgmt/2020-03-01-preview/deviceupdate [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Const `User` type has been changed from `Origin` to `CreatedByType`
info	[Changelog] - Const `System` has been removed
info	[Changelog] - Const `Usersystem` has been removed
info	[Changelog] - Struct `ErrorDefinition` has been removed
info	[Changelog] - Field `Details` of struct `ErrorResponse` has been removed
info	[Changelog] - Field `AdditionalInfo` of struct `ErrorResponse` has been removed
info	[Changelog] - Field `Code` of struct `ErrorResponse` has been removed
info	[Changelog] - Field `Message` of struct `ErrorResponse` has been removed
info	[Changelog] - Field `Target` of struct `ErrorResponse` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `None`
info	[Changelog] - New const `AlreadyExists`
info	[Changelog] - New const `Key`
info	[Changelog] - New const `ManagedIdentity`
info	[Changelog] - New const `OriginUsersystem`
info	[Changelog] - New const `OriginUser`
info	[Changelog] - New const `SystemAssigned`
info	[Changelog] - New const `Application`
info	[Changelog] - New const `Invalid`
info	[Changelog] - New const `OriginSystem`
info	[Changelog] - New function `PossibleResourceIdentityTypeValues() []ResourceIdentityType`
info	[Changelog] - New function `BaseClient.CheckNameAvailabilityResponder(*http.Response) (CheckNameAvailabilityResponse, error)`
info	[Changelog] - New function `BaseClient.CheckNameAvailability(context.Context, CheckNameAvailabilityRequest) (CheckNameAvailabilityResponse, error)`
info	[Changelog] - New function `PossibleCreatedByTypeValues() []CreatedByType`
info	[Changelog] - New function `PossibleCheckNameAvailabilityReasonValues() []CheckNameAvailabilityReason`
info	[Changelog] - New function `BaseClient.CheckNameAvailabilityPreparer(context.Context, CheckNameAvailabilityRequest) (*http.Request, error)`
info	[Changelog] - New function `Identity.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `BaseClient.CheckNameAvailabilitySender(*http.Request) (*http.Response, error)`
info	[Changelog] - New struct `CheckNameAvailabilityRequest`
info	[Changelog] - New struct `CheckNameAvailabilityResponse`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `Identity`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New field `SystemData` in struct `Account`
info	[Changelog] - New field `Identity` in struct `Account`
info	[Changelog] - New field `Identity` in struct `AccountUpdate`
info	[Changelog] - New field `Error` in struct `ErrorResponse`
info	[Changelog] - New field `SystemData` in struct `Instance`
info	[Changelog]
info	[Changelog] Total 6 breaking change(s), 32 additive change(s).
info	[Changelog]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 3d15327. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-deviceupdate [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model AccountUpdate has a new parameter identity
info	[Changelog]   - Model Instance has a new parameter system_data
info	[Changelog]   - Model Account has a new parameter identity
info	[Changelog]   - Model Account has a new parameter system_data
info	[Changelog]   - Added operation group DeviceUpdateOperationsMixin
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model ErrorResponse has a new signature

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2021-04-13T20:46:19Z

Azure Pipelines successfully started running 2 pipeline(s).

abatishchev · 2021-04-14T01:10:18Z

/azp run

azure-pipelines · 2021-04-14T01:10:31Z

Azure Pipelines successfully started running 2 pipeline(s).

abatishchev · 2021-04-14T01:20:07Z

@raych1 do you know who can take a look at the Go SDK failures? It wasn't failing in the another PR for the same change and I don't know why this one triggers a failure.

openapi-workflow-bot · 2021-04-14T01:31:11Z

Hi @abatishchev, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

raych1 · 2021-04-14T05:20:03Z

@ArcturusZhang , can you have a look at GO SDK failures?

abatishchev · 2021-04-14T16:32:30Z

/azp run

azure-pipelines · 2021-04-14T16:32:44Z

Azure Pipelines successfully started running 2 pipeline(s).

Update CheckNameAvailability_Available.json

74b6291

openapi-workflow-bot bot added the FixS360 label Apr 13, 2021

openapi-sdkautomation bot mentioned this pull request Apr 13, 2021

[AutoPR track2_azure-mgmt-deviceupdate] Removed Reason from CheckNameAvailability_Available.json in DeviceUpdate AzureSDKAutomation/azure-sdk-for-python#5105

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Apr 13, 2021

openapi-sdkautomation bot mentioned this pull request Apr 13, 2021

[AutoPR Microsoft.Azure.Management.DeviceUpdate] Removed Reason from CheckNameAvailability_Available.json in DeviceUpdate AzureSDKAutomation/azure-sdk-for-net#3891

Closed

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Apr 14, 2021

raych1 self-assigned this Apr 14, 2021

openapi-pipeline-app bot added CI-BreakingChange-Go and removed BreakingChangeReviewRequired labels Apr 14, 2021

raych1 approved these changes Apr 15, 2021

View reviewed changes

raych1 merged commit 3d15327 into master Apr 15, 2021

abatishchev deleted the alexbat/deviceupdate-cna-2 branch April 15, 2021 16:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Removed Reason from CheckNameAvailability_Available.json in DeviceUpdate #13914

Removed Reason from CheckNameAvailability_Available.json in DeviceUpdate #13914

Uh oh!

abatishchev commented Apr 13, 2021 •

edited

Loading

Uh oh!

abatishchev commented Apr 13, 2021

Uh oh!

openapi-pipeline-app bot commented Apr 13, 2021 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Apr 13, 2021 •

edited

Loading

Uh oh!

azure-pipelines bot commented Apr 13, 2021

Uh oh!

abatishchev commented Apr 14, 2021

Uh oh!

azure-pipelines bot commented Apr 14, 2021

Uh oh!

abatishchev commented Apr 14, 2021 •

edited

Loading

Uh oh!

openapi-workflow-bot bot commented Apr 14, 2021

Uh oh!

raych1 commented Apr 14, 2021

Uh oh!

abatishchev commented Apr 14, 2021

Uh oh!

azure-pipelines bot commented Apr 14, 2021

Uh oh!

Uh oh!

Removed Reason from CheckNameAvailability_Available.json in DeviceUpdate #13914

Removed Reason from CheckNameAvailability_Available.json in DeviceUpdate #13914

Uh oh!

Conversation

abatishchev commented Apr 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

abatishchev commented Apr 13, 2021

Uh oh!

openapi-pipeline-app bot commented Apr 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Apr 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Uh oh!

azure-pipelines bot commented Apr 13, 2021

Uh oh!

abatishchev commented Apr 14, 2021

Uh oh!

azure-pipelines bot commented Apr 14, 2021

Uh oh!

abatishchev commented Apr 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openapi-workflow-bot bot commented Apr 14, 2021

Uh oh!

raych1 commented Apr 14, 2021

Uh oh!

abatishchev commented Apr 14, 2021

Uh oh!

azure-pipelines bot commented Apr 14, 2021

Uh oh!

Uh oh!

abatishchev commented Apr 13, 2021 •

edited

Loading

openapi-pipeline-app bot commented Apr 13, 2021 •

edited

Loading

openapi-pipeline-app bot commented Apr 13, 2021 •

edited

Loading

abatishchev commented Apr 14, 2021 •

edited

Loading