Update documentation for CustomVision Training 3.3 #28770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
| Compared specs (v0.10.8) | new version | base version |
|---|---|---|
| Training.json | v3.3(20a1d5c) | v3.3(main) |
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The old version did not support 'application/json' as a response body format. New: Training/stable/v3.3/Training.json#L252:9 Old: Training/stable/v3.3/Training.json#L270:9 |
|
The old version did not support 'application/json' as a response body format. New: Training/stable/v3.3/Training.json#L1156:9 Old: Training/stable/v3.3/Training.json#L1223:9 |
|
The old version did not support 'application/json' as a response body format. New: Training/stable/v3.3/Training.json#L1559:9 Old: Training/stable/v3.3/Training.json#L1646:9 |
|
The old version did not support 'application/json' as a response body format. New: Training/stable/v3.3/Training.json#L1917:9 Old: Training/stable/v3.3/Training.json#L2023:9 |
|
The old version did not support 'application/json' as a response body format. New: Training/stable/v3.3/Training.json#L2461:9 Old: Training/stable/v3.3/Training.json#L2591:9 |
|
The old version did not support 'application/json' as a response body format. New: Training/stable/v3.3/Training.json#L2507:9 Old: Training/stable/v3.3/Training.json#L2638:9 |
|
The old version did not support 'application/json' as a response body format. New: Training/stable/v3.3/Training.json#L2931:9 Old: Training/stable/v3.3/Training.json#L3081:9 |
|
The operation id has been changed from 'GetDomains' to 'Domains_List'. This will impact generated code. New: Training/stable/v3.3/Training.json#L14:7 Old: Training/stable/v3.3/Training.json#L14:7 |
|
The operation id has been changed from 'GetDomain' to 'Domains_Get'. This will impact generated code. New: Training/stable/v3.3/Training.json#L49:7 Old: Training/stable/v3.3/Training.json#L52:7 |
|
The operation id has been changed from 'GetProjects' to 'Projects_List'. This will impact generated code. New: Training/stable/v3.3/Training.json#L91:7 Old: Training/stable/v3.3/Training.json#L97:7 |
|
The operation id has been changed from 'CreateProject' to 'Projects_Create'. This will impact generated code. New: Training/stable/v3.3/Training.json#L124:7 Old: Training/stable/v3.3/Training.json#L133:7 |
|
The operation id has been changed from 'GetProject' to 'Projects_Get'. This will impact generated code. New: Training/stable/v3.3/Training.json#L208:7 Old: Training/stable/v3.3/Training.json#L220:7 |
|
The operation id has been changed from 'DeleteProject' to 'Projects_Delete'. This will impact generated code. New: Training/stable/v3.3/Training.json#L248:7 Old: Training/stable/v3.3/Training.json#L263:7 |
|
The operation id has been changed from 'UpdateProject' to 'Projects_Update'. This will impact generated code. New: Training/stable/v3.3/Training.json#L283:7 Old: Training/stable/v3.3/Training.json#L299:7 |
|
The operation id has been changed from 'GetArtifact' to 'Projects_GetArtifact'. This will impact generated code. New: Training/stable/v3.3/Training.json#L339:7 Old: Training/stable/v3.3/Training.json#L358:7 |
|
The operation id has been changed from 'ExportProject' to 'Projects_Export'. This will impact generated code. New: Training/stable/v3.3/Training.json#L386:7 Old: Training/stable/v3.3/Training.json#L408:7 |
|
The operation id has been changed from 'GetImages' to 'Images_List'. This will impact generated code. New: Training/stable/v3.3/Training.json#L428:7 Old: Training/stable/v3.3/Training.json#L453:7 |
|
The operation id has been changed from 'CreateImagesFromData' to 'Images_CreateFromData'. This will impact generated code. New: Training/stable/v3.3/Training.json#L544:7 Old: Training/stable/v3.3/Training.json#L573:7 |
|
The operation id has been changed from 'DeleteImages' to 'Images_Delete'. This will impact generated code. New: Training/stable/v3.3/Training.json#L615:7 Old: Training/stable/v3.3/Training.json#L648:7 |
|
The operation id has been changed from 'GetImageRegionProposals' to 'Images_GetRegionProposals'. This will impact generated code. New: Training/stable/v3.3/Training.json#L686:7 Old: Training/stable/v3.3/Training.json#L722:7 |
|
The operation id has been changed from 'GetImageCount' to 'Images_GetCount'. This will impact generated code. New: Training/stable/v3.3/Training.json#L737:7 Old: Training/stable/v3.3/Training.json#L777:7 |
|
The operation id has been changed from 'CreateImagesFromFiles' to 'Images_CreateFromFiles'. This will impact generated code. New: Training/stable/v3.3/Training.json#L820:7 Old: Training/stable/v3.3/Training.json#L864:7 |
|
The operation id has been changed from 'GetImagesByIds' to 'Images_ListByIds'. This will impact generated code. New: Training/stable/v3.3/Training.json#L882:7 Old: Training/stable/v3.3/Training.json#L930:7 |
|
The operation id has been changed from 'UpdateImageMetadata' to 'Images_UpdateMetadata'. This will impact generated code. New: Training/stable/v3.3/Training.json#L950:7 Old: Training/stable/v3.3/Training.json#L1002:7 |
|
The operation id has been changed from 'CreateImagesFromPredictions' to 'Images_CreateFromPredictions'. This will impact generated code. New: Training/stable/v3.3/Training.json#L1030:7 Old: Training/stable/v3.3/Training.json#L1086:7 |
|
The operation id has been changed from 'CreateImageRegions' to 'Images_CreateRegions'. This will impact generated code. New: Training/stable/v3.3/Training.json#L1092:7 Old: Training/stable/v3.3/Training.json#L1152:7 |
|
The operation id has been changed from 'DeleteImageRegions' to 'Images_DeleteRegions'. This will impact generated code. New: Training/stable/v3.3/Training.json#L1152:7 Old: Training/stable/v3.3/Training.json#L1216:7 |
|
The operation id has been changed from 'QuerySuggestedImages' to 'Images_ListSuggested'. This will impact generated code. New: Training/stable/v3.3/Training.json#L1204:7 Old: Training/stable/v3.3/Training.json#L1269:7 |
|
The operation id has been changed from 'QuerySuggestedImageCount' to 'Images_GetSuggestedCount'. This will impact generated code. New: Training/stable/v3.3/Training.json#L1269:7 Old: Training/stable/v3.3/Training.json#L1338:7 |
|
The operation id has been changed from 'GetTaggedImages' to 'Images_ListTagged'. This will impact generated code. New: Training/stable/v3.3/Training.json#L1338:7 Old: Training/stable/v3.3/Training.json#L1411:7 |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 0 Errors, 2 Warnings failed [Detail]
| Compared specs (v2.2.0) | new version | base version |
|---|---|---|
| release_3_3 | release_3_3(20a1d5c) | release_3_3(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| 'GET' operation 'Projects_Export' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Training/stable/v3.3/Training.json#L388 |
||
| 'DELETE' operation 'Iterations_Unpublish' should use method name 'Delete'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Training/stable/v3.3/Training.json#L2459 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Training/stable/v3.3/Training.json#L156 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Training/stable/v3.3/Training.json#L173 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Training/stable/v3.3/Training.json#L470 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Training/stable/v3.3/Training.json#L489 |
|
Operations with a 202 response must specify x-ms-long-running-operation: true. GET operation is excluded from the validation as GET will have 202 only if it is a polling action & hence x-ms-long-running-operation wouldn't be definedLocation: Training/stable/v3.3/Training.json#L615 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Training/stable/v3.3/Training.json#L764 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Training/stable/v3.3/Training.json#L994 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Training/stable/v3.3/Training.json#L1315 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Training/stable/v3.3/Training.json#L1380 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Training/stable/v3.3/Training.json#L1649 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Training/stable/v3.3/Training.json#L2102 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Training/stable/v3.3/Training.json#L2116 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Training/stable/v3.3/Training.json#L2265 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Training/stable/v3.3/Training.json#L2835 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Training/stable/v3.3/Training.json#L3129 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Training/stable/v3.3/Training.json#L4466 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Training/stable/v3.3/Training.json#L4898 |
|
The host parameter must be called 'endpoint'. Location: Training/stable/v3.3/Training.json#L5440 |
|
The host parameter must be typed 'type 'string', format 'url''. Location: Training/stable/v3.3/Training.json#L5440 |
| API version should be a date in YYYY-MM-DD format, optionally suffixed with '-preview'. Location: Training/stable/v3.3/Training.json#L4 |
|
| Version segment 'v3.3' in basePath violates Azure versioning policy. Location: Training/stable/v3.3/Training.json#L8 |
|
| Operation does not define an 'api-version' query parameter. Location: Training/stable/v3.3/Training.json#L23 |
|
| Error response should contain a x-ms-error-code header. Location: Training/stable/v3.3/Training.json#L34 |
|
Error response schema should contain an object property named error.Location: Training/stable/v3.3/Training.json#L36 |
|
| Operation does not define an 'api-version' query parameter. Location: Training/stable/v3.3/Training.json#L58 |
|
| Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Training/stable/v3.3/Training.json#L59 |
|
| Avoid the use of x-nullable. Location: Training/stable/v3.3/Training.json#L66 |
|
| Error response should contain a x-ms-error-code header. Location: Training/stable/v3.3/Training.json#L76 |
|
Error response schema should contain an object property named error.Location: Training/stable/v3.3/Training.json#L78 |
|
| Operation does not define an 'api-version' query parameter. Location: Training/stable/v3.3/Training.json#L100 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
|
|
bojunehsu
approved these changes
Apr 23, 2024
bojunehsu
approved these changes
Apr 25, 2024
mikekistler
added
the
BreakingChange-Approved-Benign
|
/pr RequestMerge |
|
There are two lintDiff warnings. I doubt that its worth fixing them in the context of this work to improve docs.... so approving lintdiff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API - Pull Request
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Checks stuck in `queued` state?
If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`. This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.