-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Updated the LocalizedMapView
enum to reflect the addition of the US view
#34561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested to accommodate for US View - Label changes to "Gulf of Ameria" for US View Only._
@Azure/api-stewardship-board @allenjzhang @mario-guerra Could you please review the PR? Thanks! |
This PR requires review/approval of the deviation from Azure Versioning Policy. Pls come to the next Breaking Changes Office hours to discuss. Normally these are Mondays at 10-11 AM, but are cancelled next week due to the US holiday, so the next office hours will be Monday 6/2. You can also email the Azure Breaking Change reviewers to explain why the Versioning policy is not being followed, or if you need an explanation for why the PR was flagged as non-compliant. |
@Azure/api-stewardship-board @mikekistler The executive order " requirement to add a new Geopol view across all productscame in from GlobalReadiness (CELA) in response to political events in the United States immediately. This includes 'Auto' detection in old versions of the API and making it available across the full product as fast as possible. The US-View fall under these CELA guidelines. Additionally, this does not change the type/fields returned in the response only specific values. It will not break old clients. @FarazGIS |
Data Plane API Specification Update Pull Request
🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨
Updated the
LocalizedMapView
enum to reflect the addition of the US view, as per @fatercerosUpdated in specification/maps/data-plane/Common/preview/1.0/common.json
This enum is referenced by the following Azure Maps Services/versions:
Render: v1.0, v2022-08-01, v2024-04-01
Search: v1.0
🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Release planner
A release plan should have been created. If not, please create one as it will help guide you through the REST API and SDK creation process.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Getting help
write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.