Kusto: Added more features such as: database operations, check cluste…

[liatbezalel]

…r/database name availability, cluster - start/stop, event hub data connection, list skus, list resource skus. Added new api version (features are identical to the older version).

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[AutorestCI]

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

[AutorestCI]

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3391

[AutorestCI]

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

[AutorestCI]

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

[AutorestCI]

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

[azuresdkci]

Can one of the admins verify this patch?

[annatisch]

This PR is a continuation of #3595 which has already received ARM sign-off.

[annatisch]

Thanks @liatbezalel - could you please fix the CI? There seems to be missing references:

Uncaught Error: /home/travis/build/Azure/azure-rest-api-specs/specification/azure-kusto/resource-manager/Microsoft.Kusto/2017-09-07-privatepreview/kusto.json has references that cannot be resolved. They are as follows:
'Error opening file "/home/travis/build/Azure/azure-rest-api-specs/specification/azure-kusto/resource-manager/Microsoft.Kusto/2017-09-07-privatepreview/examples/KustDataconnectionValidation.json" \nENOENT: no such file or directory, open \'/home/travis/build/Azure/azure-rest-api-specs/specification/azure-kusto/resource-manager/Microsoft.Kusto/2017-09-07-privatepreview/examples/KustDataconnectionValidation.json\''

[annatisch]

Also @liatbezalel - I see that there are now two new specs in this PR - preview and privatepreview.
What's the difference between them and does the 2nd spec also require ARM sign-off?

[liatbezalel]

@annatisch they are both identical, so there is no need for ARM sign-off. (Also fixed the missing reference).

[annatisch]

Thanks @liatbezalel!
There are still some linter errors (ARM violations):
https://github.com/Azure/azure-rest-api-specs/pull/3895/checks?check_run_id=17718124#user-content-ARM-Errors

There's also a large number of model validation errors:
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/429432043

[liatbezalel]

@annatisch everything is green now :)

[annatisch]

Thanks @liatbezalel - I will try to review this afternoon

[liatbezalel]

@annatisch ping

[annatisch]

Looks pretty good - just a few minor things.
In addition to my review comments - a couple of general things:

• Please check the descriptions to capitalize abbreviations (e.g. URI, GUID, ID etc) and using capital letters at the start and period at the end.
• Please move the spec files into "stable" or "preview" subfolders. Please take a look at other service spec directory structure to see how this is done.

Thanks! :)

[AutorestCI]

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

[liatbezalel]

thanks @annatisch, resolved all your comments.

[annatisch]

Thanks @liatbezalel!
It looks like you will need to update the relative references to the common types since the change in directory structure, e.g.:

azure-rest-api-specs/specification/azure-kusto/resource-manager/Microsoft.Kusto/preview/2017-09-07-privatepreview/kusto.json

Line 1619 in 4a44ff3

"$ref": "../../../../common-types/resource-management/v1/types.json#/definitions/TrackedResource"

[liatbezalel]

@annatisch fixed :)

[annatisch]

Thanks @liatbezalel - it looks good.
Two points:

• I'm really sorry but I think I made a mistake in my feedback - looking at it more closely, I think this operation should be called "Clusters_ListSkusByResource rather than "Clusters_ListSkusByResourceGroup" as it takes the cluster resource name as a parameters as well as the group.
• Are you aware that there will be breaking changes in the Python SDK? While I'm not certain, there may be breaking changes in other language SDKs as well - are you okay with a major version bump for these new features?

Thanks!

[liatbezalel]

@annatisch

1. Changed.
2. We are ok with that, it won't break anything.