Skip to content

add customKeyIdentifier to password credential #4507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2018
Merged

add customKeyIdentifier to password credential #4507

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d1a131
add customKeyIdentifier to password credential
yugangw-msft Nov 20, 2018
1c42b12
add creds in app object
yugangw-msft Nov 25, 2018
74a0ba3
custom id(thumbprint) for cert creds should be string type
yugangw-msft Nov 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions specification/graphrbac/data-plane/stable/1.6/graphrbac.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2465,7 +2465,6 @@
},
"customKeyIdentifier": {
"type":"string",
"format": "byte",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cert based id should be a plain string with the thumbprint as the value

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

byte – base64-encoded characters, for example, U3dhZ2dlciByb2Nrcw==

So it depends only if you have base64 string on the wire. If yes, the right value is "byte". If no, the right value is "string"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After check, this string is actually not byte on the wire and the fix is right.

"description": "Custom Key Identifier"
}
},
Expand Down Expand Up @@ -2494,6 +2493,11 @@
"value": {
"type": "string",
"description": "Key value."
},
"customKeyIdentifier": {
"type": "string",
"format": "byte",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

byte – base64-encoded characters, for example, U3dhZ2dlciByb2Nrcw==

So it depends only if you have base64 string on the wire. If yes, the right value is "byte". If no, the right value is "string"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked on Fiddler, this one is definitley base64 (and then byte)

"description": "Custom Key Identifier"
}
},
"additionalProperties": {
Expand Down Expand Up @@ -2735,16 +2739,30 @@
"type": "string",
"description": "The home page of the application."
},
"oauth2AllowImplicitFlow" : {
"oauth2AllowImplicitFlow": {
"type": "boolean",
"description": "Whether to allow implicit grant flow for OAuth2"
},
"requiredResourceAccess" : {
"requiredResourceAccess": {
"type": "array",
"items": {
"$ref": "#/definitions/RequiredResourceAccess"
},
"description": "Specifies resources that this application requires access to and the set of OAuth permission scopes and application roles that it needs under each of those resources. This pre-configuration of required resource access drives the consent experience."
},
"keyCredentials": {
"type": "array",
"items": {
"$ref": "#/definitions/KeyCredential"
},
"description": "A collection of KeyCredential objects."
},
"passwordCredentials": {
"type": "array",
"items": {
"$ref": "#/definitions/PasswordCredential"
},
"description": "A collection of PasswordCredential objects"
}
},
"description": "Active Directory application information."
Expand Down