Skip to content

New operations for adhealth #5431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Mar 22, 2019
Merged

New operations for adhealth #5431

merged 18 commits into from
Mar 22, 2019

Conversation

binilkk
Copy link
Contributor

@binilkk binilkk commented Mar 20, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.
    Lint check got stuck, have restarted

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

binilkk added 13 commits December 10, 2018 21:11
@binilkk
Fixes for:
5269a33 
Issue Azure#1 : Azure#4576 (comment)

Typo in the DeltaOperationType Enum.

Issue Azure#2 : Azure#4844 (comment)

GlobalAdmins list is marked as an object, while it's an array.
@binilkk
Merge branch 'master' of https://github.com/azure/azure-rest-api-specs …
0d7d1ac 
…into dev-adhybridhealthservice-Microsoft.ADHybridHealthService-2014-01-01-binilkk
@binilkk
Merge branch 'master' of https://github.com/azure/azure-rest-api-specs …
010817d 
…into dev-adhybridhealthservice-Microsoft.ADHybridHealthService-2014-01-01-binilkk
@binilkk
Updated the Specification as example for Risky IP Download report.
b251b90
@binilkk
Added the Result details
515dcb5
@binilkk
Merge branch 'master' of https://github.com/azure/azure-rest-api-specs …
77abaa8 
…into dev-adhybridhealthservice-Microsoft.ADHybridHealthService-2014-01-01-binilkk
@binilkk
Fixed review comments, changed the URI scheme as well as changed get/…
00a8482 
…post methods
@binilkk
Merge branch 'master' of https://github.com/azure/azure-rest-api-specs …
37ed054 
…into dev-adhybridhealthservice-Microsoft.ADHybridHealthService-2014-01-01-binilkk
@binilkk
Addressing Review Feedback, changing POST call of blobUri -> generate…
74422c4 
…BlobUri
@binilkk
Merge branch 'master' of https://github.com/azure/azure-rest-api-specs …
a3a8cea 
…into dev-adhybridhealthservice-Microsoft.ADHybridHealthService-2014-01-01-binilkk
@binilkk
Added new operation to get connector metadata.
04ddb18
@binilkk
Merge branch 'master' of https://github.com/azure/azure-rest-api-specs …
2ff7922 
…into dev-adhybridhealthservice-Microsoft.ADHybridHealthService-2014-01-01-binilkk
@binilkk
Merge branch 'master' of https://github.com/azure/azure-rest-api-specs …
229a535 
…into dev-adhybridhealthservice-Microsoft.ADHybridHealthService-2014-01-01-binilkk
@AutorestCI
Copy link

AutorestCI commented Mar 20, 2019 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Mar 20, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Mar 20, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 20, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3883

@azuresdkci azuresdkci requested a review from praries880 March 20, 2019 00:34
@AutorestCI AutorestCI mentioned this pull request Mar 20, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 20, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4369

@AutorestCI
Copy link

AutorestCI commented Mar 20, 2019 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Mar 20, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 20, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3002

@praries880 praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 20, 2019
anthony-c-martin
anthony-c-martin requested changes Mar 20, 2019
View reviewed changes
binilkk added 2 commits March 20, 2019 16:44
@binilkk
Merge branch 'master' of https://github.com/azure/azure-rest-api-specs …
522535b 
…into dev-adhybridhealthservice-Microsoft.ADHybridHealthService-2014-01-01-binilkk
@binilkk
Addressing PR Comments
bded5d8
@praries880 praries880 added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 22, 2019
@praries880 praries880 closed this Mar 22, 2019
@praries880 praries880 reopened this Mar 22, 2019
@praries880
Copy link

closed and re-opened the PR to kick off CI again

This was referenced Mar 22, 2019
Merged
Merged
Merged
@praries880 praries880 merged commit e5a6df2 into Azure:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@praries880 praries880 praries880 approved these changes

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

Assignees

@praries880 praries880

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@binilkk @AutorestCI @azuresdkci @praries880 @nschonni @anthony-c-martin