Skip to content

Update Maven cache cleaning script for edge case #45146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented Apr 28, 2025

Description

Updates the Remove-Azure-Artifacts-From-Cache.ps1 script to handle an edge case where both the local build and Maven central metadata indicate that the project exists.

image

This image from one of the CI runs during a commit where I changed the version of azure-core-http-jdk-httpclient to an already released version it will delete the locally built version, even though 1.0.3 also exists in Maven central.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft added the EngSys This issue is impacting the engineering system. label Apr 28, 2025
@alzimmermsft alzimmermsft self-assigned this Apr 28, 2025
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@alzimmermsft
Copy link
Member Author

/check-enforcer override

@alzimmermsft
Copy link
Member Author

Failing / timed out CI run unrelated to changes made in PR

@alzimmermsft alzimmermsft merged commit 5801686 into Azure:main Apr 29, 2025
23 of 25 checks passed
@alzimmermsft alzimmermsft deleted the AzEng_ImproveMavenCacheCleanupScript branch April 29, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants