Changes for Management.Sql to allow customers to add TDE keys and set TDE protector for managed instances #4738
Conversation
… TDE protector for managed instances
- Bumping client version - Adding test session records -Removing unrelated messages in csproj
…oduction bug and updating session records
src/SDKs/SqlManagement/Management.Sql/Microsoft.Azure.Management.Sql.csproj
Outdated
Show resolved
Hide resolved
src/SDKs/SqlManagement/Management.Sql/Microsoft.Azure.Management.Sql.csproj
Outdated
Show resolved
Hide resolved
src/SDKs/SqlManagement/Management.Sql/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
| @@ -53,12 +55,13 @@ public void TestCreateUpdateDropServerKey() | |||
| var keyList = sqlClient.ServerKeys.ListByServer(resourceGroup.Name, server.Name); | |||
| Assert.Equal(2, keyList.Count()); | |||
|
|
|||
| // Delete key | |||
| sqlClient.ServerKeys.Delete(resourceGroup.Name, server.Name, serverKeyName); | |||
| //TODO: Temporarily disabling this since delete operation is affected by a production bug. | |||
There was a problem hiding this comment.
What is the production bug? We should avoid publishing an SDK that has known issues.
There was a problem hiding this comment.
Hi Jared,
The bug is in management service where the post condition checks are failing even on operation success. This issue seems to affect multiple APIs in prod. Management service team is currently investigating the issue.
It is important to note that the failure occurs in an existing functionality (sqlClient.ServerKeys.Delete() method which was released last year) and is not caused by this change.
There was a problem hiding this comment.
Not related to managed instance keys.
- reverted the version to 1.20.0 - revised the release notes
| @@ -56,6 +56,8 @@ internal static partial class SdkInfo | |||
| new Tuple<string, string, string>("Sql", "Jobs", "2017-03-01-preview"), | |||
| new Tuple<string, string, string>("Sql", "LongTermRetentionBackups", "2017-03-01-preview"), | |||
| new Tuple<string, string, string>("Sql", "ManagedDatabases", "2017-03-01-preview"), | |||
| new Tuple<string, string, string>("Sql", "ManagedInstanceEncryptionProtectors", "2017-10-01-preview"), | |||
| new Tuple<string, string, string>("Sql", "ManagedInstanceKeys", "2017-10-01-preview"), | |||
There was a problem hiding this comment.
Please run msbuild build.proj /t:Build /p:Scope=SDKs\SqlManagement and check in any changes generated
There was a problem hiding this comment.
I do not see anything else being generated. Is there anything specific that you are looking for?
There was a problem hiding this comment.
If there's nothing generated, we are good.
src/SDKs/SqlManagement/Management.Sql/Microsoft.Azure.Management.Sql.csproj
Show resolved
Hide resolved
Description
Changes for Management.Sql to allow customers to add TDE keys and set TDE protector for managed instances
Rest api spec PR
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.