[WIP] KeyVault Track 2 SDK adoption #10128
Conversation
|
Can one of the admins verify this patch? |
|
this PR is experiment for Track 2 SDK generation, pls do NOT review or merge. thanks. |
bim-msft
changed the title
bim-msft
force-pushed
the
bim_kv_track2
branch
2 times, most recently
from
19c5284 to
5921a05
Compare
| # license information. | ||
| # -------------------------------------------------------------------------- | ||
|
|
||
| VERSION = "0.1.0" |
There was a problem hiding this comment.
3.0.0b1 ?
Thanks, I will bump the version here.
|
hey @bim-msft can you regenerate using https://github.com/Azure/autorest.python/releases/tag/v5.0.0-dev.20200326.1? This will remove the "azure-" prefix from the user agent name to fulfill library guidelines (also includes other fixes, not sure how / if they apply here) Thanks so much! |
Thanks @iscai-msft for the info. Just a question about userAgent in general, should |
@iscai-msft Thanks, I will have a try. |
sdk/keyvault/azure-mgmt-keyvault-autorestv5/azure/mgmt/keyvault/v2018_02_14/models/_models.py
Show resolved
Hide resolved
| @@ -119,16 +120,21 @@ def __init__(self, client, config, serializer, deserializer) -> None: | |||
| :param private_endpoint_connection_name: Name of the private endpoint connection associated | |||
| with the key vault. | |||
| :type private_endpoint_connection_name: str | |||
| :param properties: The intended state of private endpoint connection. | |||
| :type properties: ~azure.mgmt.keyvault.v2018_02_14.models.PrivateEndpointConnection | |||
| :param private_endpoint: Properties of the private endpoint object. | |||
There was a problem hiding this comment.
Just want to make sure: when you regenerated this time, did you specify a payload flattening threshold? Did your command change in any ways?
There was a problem hiding this comment.
Just want to make sure: when you regenerated this time, did you specify a payload flattening threshold? Did your command change in any ways?
@iscai-msft No, I didn't change my regen command.
autorest --python --use=/mnt/c/repos/autorest.python /mnt/c/repos/azure-rest-api-specs/specification/keyvault/resource-manager/readme.md --multiapi --python-sdks-folder=/mnt/c/repos/azure-sdk-for-python/sdk --debug
Regened again, nothing changed.
|
Closing it due to we have a larger coverage now: #11484 |
WIP: DO NOT MERGE